Skip to content

fix: stop SMGC service on SR detach to prevent orphaned systemd units - #92

Merged
Millefeuille42 merged 1 commit into
3.2.12-8.3from
mlr-970-cleanup-SMGC-units
Oct 6, 2025
Merged

fix: stop SMGC service on SR detach to prevent orphaned systemd units#92
Millefeuille42 merged 1 commit into
3.2.12-8.3from
mlr-970-cleanup-SMGC-units

Conversation

@Millefeuille42

@Millefeuille42 Millefeuille42 commented Jul 22, 2025 •
edited
Loading

Copy link
Copy Markdown

This is not done on every and each implementation of SR but only on ones that calls cleanup.start_gc_service (like FileSR) and on the classes that inherits from them and don't call super on detach (like CephFSSR).

This is to prevent useless errors logs like Failed to stop xxx.service: Unit xxx.service not loaded.

@Millefeuille42 Millefeuille42 self-assigned this Jul 22, 2025
Wescoeur
Wescoeur requested changes Aug 19, 2025
View reviewed changes
Comment thread drivers/cleanup.py
Comment on lines +4055 to +4066
def stop_gc_service(sr_uuid):
"""
Stops the templated systemd service which runs GC on the given SR UUID.
"""
sr_uuid_esc = sr_uuid.replace("-", "\\x2d")
util.SMlog(f"Stopping SMGC@{sr_uuid}...")
cmd = ["/usr/bin/systemctl", "--quiet", "stop", f"SMGC@{sr_uuid_esc}"]
try:
subprocess.run(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, close_fds=True, check=True)
except subprocess.CalledProcessError as e:
util.SMlog(f"Failed to stop gc service `SMGC@{sr_uuid_esc}`: `{e.stderr.decode().strip()}`")

@Wescoeur Wescoeur Aug 19, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's cleaner to use util.doexec and compact the common code with start_gc_service.

@Millefeuille42 Millefeuille42 Aug 20, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 4b1d2d9

@Millefeuille42
Millefeuille42 force-pushed the mlr-970-cleanup-SMGC-units branch from f2d41c7 to 4b1d2d9 Compare August 20, 2025 10:46
Wescoeur
Wescoeur reviewed Aug 21, 2025
View reviewed changes
Comment thread drivers/cleanup.py Outdated
Comment on lines +4041 to +4044
cmd=[ "/usr/bin/systemctl", "--quiet" ]
if extra_args:
cmd.extend(extra_args)
cmd += [action, f"SMGC@{sr_uuid_esc}"]

@Wescoeur Wescoeur Aug 21, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small difference in using arrays with and without spaces.

@Millefeuille42 Millefeuille42 Aug 21, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 95ed874

@Wescoeur

Wescoeur commented Aug 21, 2025

Copy link
Copy Markdown
Member

Before merge, it would be great to open a PR on the upstream side.

@Millefeuille42

Millefeuille42 commented Aug 21, 2025

Copy link
Copy Markdown
Author

Opened PR on upstream: xapi-project#770

@Millefeuille42
Millefeuille42 force-pushed the mlr-970-cleanup-SMGC-units branch 2 times, most recently from 23aaeb6 to 3c9feba Compare August 21, 2025 15:31
@Wescoeur
Wescoeur force-pushed the 3.2.12-8.3 branch 3 times, most recently from e7801da to ca5b52d Compare August 28, 2025 15:32
@Millefeuille42
Millefeuille42 force-pushed the mlr-970-cleanup-SMGC-units branch from 3c9feba to e2d8514 Compare September 1, 2025 15:04
@Millefeuille42
Stop SMGC service on SR detach to prevent orphaned systemd units
7af8b28 
This is not done on every and each implementation of SR but only on ones that calls cleanup.start_gc_service (like FileSR)
and on the classes that inherits from them and don't call super on detach.

This is to prevent useless errors logs like Failed to stop xxx.service: Unit xxx.service not loaded.

Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
@Millefeuille42
Millefeuille42 force-pushed the mlr-970-cleanup-SMGC-units branch from e2d8514 to 7af8b28 Compare September 22, 2025 13:02
@Millefeuille42

Millefeuille42 commented Sep 22, 2025

Copy link
Copy Markdown
Author

Upstream PR have been merged. Are we good to merge this one ?

@Wescoeur

Wescoeur commented Oct 2, 2025

Copy link
Copy Markdown
Member

@Nambrok Can you validate on your side?

@Millefeuille42
Millefeuille42 merged commit e3e8daf into 3.2.12-8.3 Oct 6, 2025
5 checks passed
@Wescoeur
Wescoeur deleted the mlr-970-cleanup-SMGC-units branch November 17, 2025 17:20
Wescoeur pushed a commit that referenced this pull request Dec 1, 2025
@Millefeuille42 @Wescoeur
Stop SMGC service on SR detach to prevent orphaned systemd units (#92)
72a2053 
This is not done on every and each implementation of SR but only on ones that calls cleanup.start_gc_service (like FileSR)
and on the classes that inherits from them and don't call super on detach.

This is to prevent useless errors logs like Failed to stop xxx.service: Unit xxx.service not loaded.

Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
Wescoeur pushed a commit that referenced this pull request Dec 1, 2025
@Millefeuille42 @Wescoeur
Stop SMGC service on SR detach to prevent orphaned systemd units (#92)
e176f29 
This is not done on every and each implementation of SR but only on ones that calls cleanup.start_gc_service (like FileSR)
and on the classes that inherits from them and don't call super on detach.

This is to prevent useless errors logs like Failed to stop xxx.service: Unit xxx.service not loaded.

Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
Wescoeur pushed a commit that referenced this pull request Dec 1, 2025
@Millefeuille42 @Wescoeur
Stop SMGC service on SR detach to prevent orphaned systemd units (#92)
e32c9c5 
This is not done on every and each implementation of SR but only on ones that calls cleanup.start_gc_service (like FileSR)
and on the classes that inherits from them and don't call super on detach.

This is to prevent useless errors logs like Failed to stop xxx.service: Unit xxx.service not loaded.

Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
Wescoeur pushed a commit that referenced this pull request Dec 9, 2025
@Millefeuille42 @Wescoeur
Stop SMGC service on SR detach to prevent orphaned systemd units (#92)
1b49eec 
This is not done on every and each implementation of SR but only on ones that calls cleanup.start_gc_service (like FileSR)
and on the classes that inherits from them and don't call super on detach.

This is to prevent useless errors logs like Failed to stop xxx.service: Unit xxx.service not loaded.

Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
Wescoeur pushed a commit that referenced this pull request Dec 9, 2025
@Millefeuille42 @Wescoeur
Stop SMGC service on SR detach to prevent orphaned systemd units (#92)
aa95fd6 
This is not done on every and each implementation of SR but only on ones that calls cleanup.start_gc_service (like FileSR)
and on the classes that inherits from them and don't call super on detach.

This is to prevent useless errors logs like Failed to stop xxx.service: Unit xxx.service not loaded.

Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
Millefeuille42 added a commit that referenced this pull request Dec 10, 2025
@Millefeuille42
Stop SMGC service on SR detach to prevent orphaned systemd units (#92)
3498760 
This is not done on every and each implementation of SR but only on ones that calls cleanup.start_gc_service (like FileSR)
and on the classes that inherits from them and don't call super on detach.

This is to prevent useless errors logs like Failed to stop xxx.service: Unit xxx.service not loaded.

Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
Wescoeur pushed a commit that referenced this pull request Feb 2, 2026
@Millefeuille42 @Wescoeur
Stop SMGC service on SR detach to prevent orphaned systemd units (#92)
a880451 
This is not done on every and each implementation of SR but only on ones that calls cleanup.start_gc_service (like FileSR)
and on the classes that inherits from them and don't call super on detach.

This is to prevent useless errors logs like Failed to stop xxx.service: Unit xxx.service not loaded.

Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
Wescoeur pushed a commit that referenced this pull request Feb 3, 2026
@Millefeuille42 @Wescoeur
Stop SMGC service on SR detach to prevent orphaned systemd units (#92)
e450fce 
This is not done on every and each implementation of SR but only on ones that calls cleanup.start_gc_service (like FileSR)
and on the classes that inherits from them and don't call super on detach.

This is to prevent useless errors logs like Failed to stop xxx.service: Unit xxx.service not loaded.

Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
Wescoeur pushed a commit that referenced this pull request Feb 3, 2026
@Millefeuille42 @Wescoeur
Stop SMGC service on SR detach to prevent orphaned systemd units (#92)
97c92a7 
This is not done on every and each implementation of SR but only on ones that calls cleanup.start_gc_service (like FileSR)
and on the classes that inherits from them and don't call super on detach.

This is to prevent useless errors logs like Failed to stop xxx.service: Unit xxx.service not loaded.

Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
Wescoeur pushed a commit that referenced this pull request Feb 3, 2026
@Millefeuille42 @Wescoeur
Stop SMGC service on SR detach to prevent orphaned systemd units (#92)
5a21a25 
This is not done on every and each implementation of SR but only on ones that calls cleanup.start_gc_service (like FileSR)
and on the classes that inherits from them and don't call super on detach.

This is to prevent useless errors logs like Failed to stop xxx.service: Unit xxx.service not loaded.

Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
Wescoeur pushed a commit that referenced this pull request May 19, 2026
@Millefeuille42 @Wescoeur
Stop SMGC service on SR detach to prevent orphaned systemd units (#92)
0d798f4 
This is not done on every and each implementation of SR but only on ones that calls cleanup.start_gc_service (like FileSR)
and on the classes that inherits from them and don't call super on detach.

This is to prevent useless errors logs like Failed to stop xxx.service: Unit xxx.service not loaded.

Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
Wescoeur pushed a commit that referenced this pull request May 19, 2026
@Millefeuille42 @Wescoeur
Stop SMGC service on SR detach to prevent orphaned systemd units (#92)
d89e43f 
This is not done on every and each implementation of SR but only on ones that calls cleanup.start_gc_service (like FileSR)
and on the classes that inherits from them and don't call super on detach.

This is to prevent useless errors logs like Failed to stop xxx.service: Unit xxx.service not loaded.

Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
Wescoeur pushed a commit that referenced this pull request Jun 25, 2026
@Millefeuille42 @Wescoeur
Stop SMGC service on SR detach to prevent orphaned systemd units (#92)
3852d4c 
This is not done on every and each implementation of SR but only on ones that calls cleanup.start_gc_service (like FileSR)
and on the classes that inherits from them and don't call super on detach.

This is to prevent useless errors logs like Failed to stop xxx.service: Unit xxx.service not loaded.

Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
Wescoeur pushed a commit that referenced this pull request Jun 25, 2026
@Millefeuille42 @Wescoeur
Stop SMGC service on SR detach to prevent orphaned systemd units (#92)
968bbbe 
This is not done on every and each implementation of SR but only on ones that calls cleanup.start_gc_service (like FileSR)
and on the classes that inherits from them and don't call super on detach.

This is to prevent useless errors logs like Failed to stop xxx.service: Unit xxx.service not loaded.

Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
Wescoeur pushed a commit that referenced this pull request Jun 25, 2026
@Millefeuille42 @Wescoeur
Stop SMGC service on SR detach to prevent orphaned systemd units (#92)
50d9768 
This is not done on every and each implementation of SR but only on ones that calls cleanup.start_gc_service (like FileSR)
and on the classes that inherits from them and don't call super on detach.

This is to prevent useless errors logs like Failed to stop xxx.service: Unit xxx.service not loaded.

Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
Wescoeur pushed a commit that referenced this pull request Jun 25, 2026
@Millefeuille42 @Wescoeur
Stop SMGC service on SR detach to prevent orphaned systemd units (#92)
c060eec 
This is not done on every and each implementation of SR but only on ones that calls cleanup.start_gc_service (like FileSR)
and on the classes that inherits from them and don't call super on detach.

This is to prevent useless errors logs like Failed to stop xxx.service: Unit xxx.service not loaded.

Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
Wescoeur pushed a commit that referenced this pull request Jun 25, 2026
@Millefeuille42 @Wescoeur
Stop SMGC service on SR detach to prevent orphaned systemd units (#92)
db54993 
This is not done on every and each implementation of SR but only on ones that calls cleanup.start_gc_service (like FileSR)
and on the classes that inherits from them and don't call super on detach.

This is to prevent useless errors logs like Failed to stop xxx.service: Unit xxx.service not loaded.

Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wescoeur Wescoeur Wescoeur approved these changes
@Nambrok Nambrok Nambrok approved these changes

Assignees

@Millefeuille42 Millefeuille42

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Millefeuille42 @Wescoeur @Nambrok